Skip to content

Conversation

iamhowardtheduck
Copy link

@iamhowardtheduck iamhowardtheduck commented Jun 6, 2025

Change the field name date to @timestamp so that users will be able to follow along with documentation. If not, then the date field is mapped as a keyword, which confuses users.

Change the field name `date` to `@timestamp` so that users will be able to follow along with documentation.  If not, then the date field is mapped as a keyword, which confuses users.
Copy link
Contributor

github-actions bot commented Jun 6, 2025

Documentation preview:

@elasticsearchmachine
Copy link
Collaborator

@iamhowardtheduck please enable the option "Allow edits and access to secrets by maintainers" on your PR. For more information, see the documentation.

@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label external-contributor Pull request authored by a developer outside the Elasticsearch team v8.18.3 labels Jun 6, 2025
Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@leemthompo leemthompo self-assigned this Jun 6, 2025
@leemthompo leemthompo added >docs General docs changes Team:Docs Meta label for docs team auto-backport Automatically create backport pull requests when merged v8.17.0 v8.19.0 labels Jun 6, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine elasticsearchmachine removed the needs:triage Requires assignment of a team area label label Jun 6, 2025
leemthompo added a commit that referenced this pull request Jun 6, 2025
@leemthompo leemthompo merged commit 73c56a5 into 8.18 Jun 6, 2025
7 checks passed
@leemthompo leemthompo deleted the iamhowardtheduck-patch-1 branch June 6, 2025 13:36
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 129053

@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 129053

@leemthompo
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.19
8.17

Questions ?

Please refer to the Backport tool documentation

leemthompo pushed a commit to leemthompo/elasticsearch that referenced this pull request Jun 6, 2025
Change the field name `date` to `@timestamp` so that users will be able to follow along with documentation.  If not, then the date field is mapped as a keyword, which confuses users.

(cherry picked from commit 73c56a5)
leemthompo pushed a commit to leemthompo/elasticsearch that referenced this pull request Jun 6, 2025
Change the field name `date` to `@timestamp` so that users will be able to follow along with documentation.  If not, then the date field is mapped as a keyword, which confuses users.

(cherry picked from commit 73c56a5)
elasticsearchmachine pushed a commit that referenced this pull request Jun 6, 2025
Change the field name `date` to `@timestamp` so that users will be able to follow along with documentation.  If not, then the date field is mapped as a keyword, which confuses users.

(cherry picked from commit 73c56a5)

Co-authored-by: Peter Titov <[email protected]>
elasticsearchmachine pushed a commit that referenced this pull request Jun 6, 2025
Change the field name `date` to `@timestamp` so that users will be able to follow along with documentation.  If not, then the date field is mapped as a keyword, which confuses users.

(cherry picked from commit 73c56a5)

Co-authored-by: Peter Titov <[email protected]>
leemthompo added a commit that referenced this pull request Jun 16, 2025
leemthompo added a commit to leemthompo/elasticsearch that referenced this pull request Jun 16, 2025
elasticsearchmachine pushed a commit that referenced this pull request Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged backport pending >docs General docs changes external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Docs Meta label for docs team v8.17.0 v8.18.3 v8.19.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants